Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1Password op-scim-bridge to v2.8.2 #469

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

grellyd
Copy link
Contributor

@grellyd grellyd commented Jul 18, 2023

BACKGROUND

  • Add information about the background and reason for the change.

v2.10.2 of our helm chart had an error presented to Digital Ocean customers. This update brings the version forward to a helm chart version which corrects the error and updates the values.yml to prevent further errors of this kind..


Changes

  • Update to v2.10.3 of the 1Password Helm Chart
  • Add values.yml to protect against future errors of this kind.
  • Move the -set command into the values.yml

Checklist

  • review the contributing doc with steps for both adding or updating your application (if applicable)

Reviewer: @marketplace-eng

@grellyd grellyd changed the title Alice/v2.8.2 Update 1Password op-scim-bridge to v2.8.2 Jul 18, 2023
Copy link
Contributor

@mbeyt mbeyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestion - we prefer to reference the hosted version of values.yml if this isn't running locally.

stacks/op-scim-bridge/deploy.sh Outdated Show resolved Hide resolved
Co-authored-by: mbeyt <57464615+mbeyt@users.noreply.github.com>
@mbeyt mbeyt merged commit 9792166 into digitalocean:master Jul 20, 2023
@github-actions
Copy link

👋 @grellyd
If this is an EXISTING Marketplace app, now that the PR is merged, all new users of your app will get the current version. You should visit the Vendor Portal to make sure you update any version numbers, Description, or Getting Started information that are related to the merged PR.
If this is a BRAND NEW Marketplace app, before this app update can go live on the Marketplace, please update and submit your app from the Vendor Portal.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants