Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource cleanup for multiple stacks #475

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

msannan2
Copy link
Contributor

@msannan2 msannan2 commented Sep 1, 2023

BACKGROUND

  • Some kubernetes stacks do not have an uninstall script, causing some resources to remain on the cluster during the addon testing jobs runs
  • Some uninstall scripts fail which again, prevents cleanup of the resources provisioned by the stack

Changes

  • Added uninstall scripts to jaeger and victoria-metrics-server
  • Fixed existing uninstall scripts
  • Updated deploy scripts to use dedicated namespaces rather the default namespace

Reviewer: @marketplace-eng

Copy link
Contributor

@scott scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msannan2 msannan2 merged commit 9fffd63 into master Sep 5, 2023
@msannan2 msannan2 deleted the MP-6455/add-uninstall-scripts branch September 5, 2023 09:46
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

👋 @msannan2
If this is an EXISTING Marketplace app, now that the PR is merged, all new users of your app will get the current version. You should visit the Vendor Portal to make sure you update any version numbers, Description, or Getting Started information that are related to the merged PR.
If this is a BRAND NEW Marketplace app, before this app update can go live on the Marketplace, please update and submit your app from the Vendor Portal.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants