Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions to Easegress #478

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Add instructions to Easegress #478

merged 4 commits into from
Oct 13, 2023

Conversation

LokiWager
Copy link
Contributor

BACKGROUND

Changes

  • List the changes that you made
  • add stacks/easegress/README.md
  • add stacks/easegress/imgs/architecture.png
  • add stacks/easegress/values.yml

Checklist

  • review the contributing doc with steps for both adding or updating your application (if applicable)

Reviewer: @marketplace-eng

msannan2
msannan2 requested changes Sep 21, 2023
View reviewed changes
stacks/easegress/README.md Outdated
First, attach in a shell session to the Easegress pod:

```console
k -n easegress exec -ti easegress-0 /bin/sh
Copy link
Contributor

@msannan2 msannan2 Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be kubectl -n easegress exec -ti easegress-0 /bin/sh ?

stacks/easegress/README.md Outdated
export NODE_IP=$(kubectl get nodes --namespace easegress -o jsonpath="{.items[0].status.addresses[0].address}")
echo http://$NODE_IP:$NODE_PORT

http://10.108.162.15:30780
Copy link
Contributor

@msannan2 msannan2 Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested with DOKS? Is the service accessible with the NODE_IP or does it require a LoadBalancer as well?

bikram20
bikram20 previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@bikram20 bikram20 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be approved after Easegress team addresses Sannan's feedback above.

@LokiWager
Copy link
Contributor Author

I’m sorry, I didn’t receive the github notification. I will make the necessary changes as soon as possible. @bikram20 thank you.

msannan2
msannan2 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@msannan2 msannan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keladhruv keladhruv merged commit 273e964 into digitalocean:master Oct 13, 2023
@github-actions
Copy link

👋 @LokiWager
If this is an EXISTING Marketplace app, now that the PR is merged, all new users of your app will get the current version. You should visit the Vendor Portal to make sure you update any version numbers, Description, or Getting Started information that are related to the merged PR.
If this is a BRAND NEW Marketplace app, before this app update can go live on the Marketplace, please update and submit your app from the Vendor Portal.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msannan2 msannan2 msannan2 approved these changes

@bikram20 bikram20 Awaiting requested review from bikram20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LokiWager @msannan2 @bikram20 @keladhruv