Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ngrok-ingress-controller to digital ocean #492

Merged

Conversation

Abdiramen
Copy link
Contributor

BACKGROUND

Leverage ngrok for your Kubernetes Ingress. Instantly add load balancing, authentication, and observability to your services via ngrok Cloud Edge modules using Custom Resource Definitions (CRDs) and Kubernetes-native tooling.


Changes

  • Add ngrok-ingress-controller to digital ocean marketplace, by adding the following:
    • stacks/ngrok-ingress-controller/deploy.sh
    • stacks/ngrok-ingress-controller/upgrade.sh
    • stacks/ngrok-ingress-controller/uninstall.sh
    • stacks/ngrok-ingress-controller/values.sh

Checklist

  • review the contributing doc with steps for both adding or updating your application (if applicable)

Reviewer: @marketplace-eng

@Abdiramen
Copy link
Contributor Author

@keladhruv If you have the chance can you review this 😄

@Abdiramen
Copy link
Contributor Author

Hey @mbeyt, is there any chance you could review this for us 😉

Copy link
Contributor

@msannan2 msannan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msannan2 msannan2 merged commit fd55a78 into digitalocean:master Nov 30, 2023
Copy link

👋 @Abdiramen
If this is an EXISTING Marketplace app, now that the PR is merged, all new users of your app will get the current version. You should visit the Vendor Portal to make sure you update any version numbers, Description, or Getting Started information that are related to the merged PR.
If this is a BRAND NEW Marketplace app, before this app update can go live on the Marketplace, please update and submit your app from the Vendor Portal.
Thanks!

@CK-Ward
Copy link

CK-Ward commented Nov 30, 2023

Thanks so much @msannan2 !

@Abdiramen Abdiramen deleted the ngrok-ingress-controller-first-pr branch November 30, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants