Skip to content

GATEWAYS-4306: exporting metrics for conntrack per zone #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

GATEWAYS-4306: exporting metrics for conntrack per zone #21

wants to merge 4 commits into from

Conversation

shrouti1995
Copy link
Collaborator

@shrouti1995 shrouti1995 commented Aug 13, 2025 •
edited
Loading

Adding support to export conntrack metrics per zone.
Details:

  1. Used netlink API via go-openvswitch/ovsnl package
  2. Implemented proper metric collection through Prometheus collector interface

@shrouti1995 shrouti1995 requested a review from Copilot August 13, 2025 10:39
Copilot
Copilot AI reviewed Aug 13, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@shrouti1995 shrouti1995 marked this pull request as draft August 13, 2025 10:51
jcooperdo
jcooperdo reviewed Sep 29, 2025
View reviewed changes
internal/ovsexporter/conntrack.go
// ConntrackCollectorWithAggAccessor wraps the existing collector with access to the aggregator snapshot
type ConntrackCollectorWithAggAccessor struct {
*conntrackCollector
SnapshotFunc func() map[uint16]map[uint32]int
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@jcooperdo jcooperdo jcooperdo left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrouti1995 @jcooperdo