Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Kafka topics #1052

Merged
merged 14 commits into from
Oct 23, 2023
Merged

Add support for Kafka topics #1052

merged 14 commits into from
Oct 23, 2023

Conversation

dweinshenker
Copy link
Contributor

@dweinshenker dweinshenker commented Oct 16, 2023 •
edited
Loading

What

Testing

Ran TestAccDigitalOceanUptimeAlert_Basic and TestAccDigitalOceanDatabaseKafkaTopic acceptance tests locally

@dweinshenker dweinshenker marked this pull request as ready for review October 18, 2023 04:53
andrewsomething
andrewsomething approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@andrewsomething andrewsomething merged commit 6bcb253 into digitalocean:main Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweinshenker @andrewsomething