Removed rem size hack, closes #192 #196
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the rem size hack as described in #192 and replacing it with a SASS function (from the article mentioned in the issue
).
The sizes might be wonky! The change from 1rem = 10px to rem function was made with VSCode replace using Regex, so errors are possible. No problems with building or stylelint, though.
Note: CSS variables must use the compile time syntax #{rem(16px)} for it to work. Using it straight in statements or in SCSS variables is fine.
Closes #192