Skip to content

Refresh URL in web admin with current scope #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refresh URL in web admin with current scope #1476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/components/Admin/common/RepositorySidebarOverlay/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
type HistoryEntryLocation
} from "../../../../history/History";
import { usePrevious } from "../../../../hooks/usePrevious";
import { useStableSearchParams } from "../../../../hooks/useStableSearchParams";
import {
digmaApi,
useGetSpanInfoQuery
Expand Down Expand Up @@ -87,6 +88,7 @@
() => new History<RepositorySidebarHistoryState>([])
);
const previousIsSidebarOpen = usePrevious(isSidebarOpen);
const [, setSearchParams] = useStableSearchParams();

const { data: spanInfo } = useGetSpanInfoQuery(
{ spanCodeObjectId: currentSpanCodeObjectId ?? "" },
Expand Down Expand Up @@ -130,9 +132,17 @@
e: CustomEvent<HistoryEntry<RepositorySidebarHistoryState>>
) => {
setCurrentSpanCodeObjectId(e.detail.state?.spanCodeObjectId);
setCurrentTabLocation(
e.detail.state?.tabLocation ?? { id: TAB_IDS.ISSUES }
);
const newTabLocation = e.detail.state?.tabLocation ?? {
id: TAB_IDS.ISSUES
};
setCurrentTabLocation(newTabLocation);
setSearchParams((params) => {
if (spanInfo?.uid) {
params.set("sidebar-scope", spanInfo.uid);
}
params.set("sidebar-view", JSON.stringify(newTabLocation));
return params;
});
};

window.addEventListener(
Expand All @@ -154,7 +164,7 @@
handleHistoryChangeOrNavigate as EventListener
);
};
}, []);

Check warning on line 167 in src/components/Admin/common/RepositorySidebarOverlay/index.tsx

View workflow job for this annotation

GitHub Actions / Lint & test / build 

React Hook useEffect has missing dependencies: 'setSearchParams' and 'spanInfo.uid'. Either include them or remove the dependency array

useEffect(() => {
const newSpanCodeObjectId = sidebarQuery?.query?.scopedSpanCodeObjectId;
Expand Down
1 change: 1 addition & 0 deletions src/redux/services/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,6 +1037,7 @@ export interface GetSpanInfoResponse {
firstSeen?: string;
lastSeen?: string;
linkedEndpoints?: LinkedEndpoint[];
uid?: string;
}

export interface GetSpanEnvironmentsPayload {
Expand Down
Loading