Skip to content

Fix N+1 query performance issue in Vet.specialties relationship #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix N+1 query performance issue in Vet.specialties relationship #107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21af901
Fix N+1 query issue in Vet specialties field by changing to lazy fetc…
shaykeren Aug 5, 2025
9358dc6
Fix import formatting and add missing BatchSize import
shaykeren Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/main/java/org/springframework/samples/petclinic/vet/Vet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,17 @@
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;

import org.springframework.beans.support.MutableSortDefinition;
import java.util.Set;import org.springframework.beans.support.MutableSortDefinition;
import org.springframework.beans.support.PropertyComparator;
import org.springframework.samples.petclinic.model.Person;

import jakarta.persistence.Entity;
import jakarta.persistence.FetchType;
import jakarta.persistence.JoinColumn;
import jakarta.persistence.JoinTable;
import jakarta.persistence.ManyToMany;
import jakarta.persistence.Table;
import jakarta.xml.bind.annotation.XmlElement;
import org.hibernate.annotations.BatchSize;

/**
* Simple JavaBean domain object representing a veterinarian.
Expand All @@ -45,12 +43,11 @@
@Table(name = "vets")
public class Vet extends Person {

@ManyToMany(fetch = FetchType.EAGER)
@BatchSize(size = 10)
@ManyToMany(fetch = FetchType.LAZY)
@JoinTable(name = "vet_specialties", joinColumns = @JoinColumn(name = "vet_id"),
inverseJoinColumns = @JoinColumn(name = "specialty_id"))
private Set<Specialty> specialties;

protected Set<Specialty> getSpecialtiesInternal() {
private Set<Specialty> specialties;protected Set<Specialty> getSpecialtiesInternal() {
if (this.specialties == null) {
this.specialties = new HashSet<>();
}
Expand All @@ -76,4 +73,4 @@ public void addSpecialty(Specialty specialty) {
getSpecialtiesInternal().add(specialty);
}

}
}