Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behaviour of DigraphRemoveEdge/DigraphRemoveEdges is inconsistent #260 #723

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Behaviour of DigraphRemoveEdge/DigraphRemoveEdges is inconsistent #260 #723

wants to merge 5 commits into from

Conversation

saffronmciver
Copy link
Contributor

  • Edited functions for DigraphRemoveEdge, DigraphRemoveEdges, DigraphReverseEdge, DigraphReverseEdges, DigraphRemoveVertices and QuotientGraph.
  • Checks added to see if any work needs to be done before making a copy.

Saffron and others added 3 commits February 5, 2025 13:24
Edit functions to not return unnecessary copies
2492f10 
- Edited functions for DigraphRemoveEdge, DigraphRemoveEdges,
  DigraphReverseEdge, DigraphReverseEdges, DigraphRemoveVertices and
QuotientGraph
- Checks added to see if any work needs to be done before making a copy
@saffronmciver
Fix unbound local variable
6e704ab
@saffronmciver
Fix gaplint errors
cc2feb9
@saffronmciver
Copy link
Contributor Author

DigraphsTestsStandard fails due to a test expecting output where the attributes of a graph are retained after the immutable call of DigraphRemoveVertices.

@james-d-mitchell
Copy link
Member

@saffronmciver if you pull from main and then rebase your branch then hopefully the lint job will pass

@saffronmciver saffronmciver marked this pull request as ready for review February 7, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saffronmciver @james-d-mitchell