Skip to content

Add SwapDigraphs and DigraphsRemoveAllEdges functions #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add SwapDigraphs and DigraphsRemoveAllEdges functions #864

wants to merge 6 commits into from
+132 −0

Conversation

RheyaM
Copy link

@RheyaM RheyaM commented Oct 1, 2025 •
edited by wilfwilson
Loading

Created SwapDigraphs to swap the contents of two digraphs, and added DigraphsRemoveAllEdges for removing all edges from a digraph

mtorpey
mtorpey previously requested changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@mtorpey mtorpey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, especially for your first pull request. I've suggested a load of changes (we always do this) so it'd be great if you could make those changes and we can get this merged. Sorry for the major changes I'm requesting to the core algorithm!

@wilfwilson wilfwilson changed the title Added SwapDigraphs and DigraphsRemoveAllEdges functions Add SwapDigraphs and DigraphsRemoveAllEdges functions Oct 1, 2025
james-d-mitchell
james-d-mitchell requested changes Oct 7, 2025
View reviewed changes
Copy link
Member

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent start, but this Pr will need some changes before it can be merged, let's discuss tomorrow!

@mtorpey mtorpey dismissed their stale review October 8, 2025 11:16

Mostly fixed, with remaining problems covered by @james-d-mitchell's review.

mtorpey
mtorpey reviewed Oct 8, 2025
View reviewed changes
mtorpey
mtorpey reviewed Oct 8, 2025
View reviewed changes
mtorpey
mtorpey reviewed Oct 8, 2025
View reviewed changes
mtorpey
mtorpey requested changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@mtorpey mtorpey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close to complete now. Just a couple more comments.

mtorpey
mtorpey approved these changes Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@mtorpey mtorpey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me now!

I think @james-d-mitchell's suggestions have now been fixed, but I'll let him approve before merging.

@wilfwilson
Copy link
Collaborator

Very nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james-d-mitchell james-d-mitchell james-d-mitchell requested changes

@mtorpey mtorpey mtorpey approved these changes

@wilfwilson wilfwilson wilfwilson approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RheyaM @wilfwilson @mtorpey @james-d-mitchell @rm387