Implement margin auto #403
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #67
This still needs more tests and documentation before it's ready to go but I wanted to post the PR to start getting feedback as early as possible. This is a big change so I expect it will end up needing many revisions.
Overview
Some changes that were made as prerequisites:
style.marginis now a length instead of just a valuemarginLeft,marginRight,marginTop, andmarginBottomfunctions for converting back to a value. Percent and auto are treated as 0 by this function.boxOffsetX,boxRestWidth, andboxDiffWidthare moved from style to widget under the namesmarginBoxOffsetX,marginBoxRestWidth, andmarginBoxDiffWidth.marginfield is added to theWidgetclass.The main logic is as follows:
calcWidthcomputes margin widths and returns aBoxWidthstruct that contains the computed margin sizes instead of just the total size.calcFinalWidthsetswidget.margin.leftandwidget.margin.rightbased on what it picked as the final size.marginBoxOffsetX,marginBoxRestWidth, andmarginBoxDiffWidthfunctions use the savedwidget.marginvalues instead ofstyle.marginvalues.This works because
getAvailableWidthis always called before any ofboxOffsetX,boxRestWidthorboxDiffWidth. This meanscalcFinalWidthis guaranteed to have already run.Screenshots
The margin auto test passing

The dillo website correctly centered now
