Upgrade kombu==5.4.2 #36032
Merged
Upgrade kombu==5.4.2 #36032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitPhulera
approved these changes
Mar 24, 2025
|
Confirmed that Celery on staging looks good since this was deployed there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bump for Python 3.13 compatibility. Reviewed release notes and recent issues. This bug is the reason that this PR is not going all the way to v5.5 just yet. Given the greenness of v5.5 (released days ago), it seems prudent to wait for that to stabilize (major change: drop pycurl in favor of urllib3), even though 5.4.2 does not officially support Python 3.13. Hopefully a better solution will be available before we upgrade our production environments to Python 3.13.
There is a question about whether Celery should also be updated to 5.3 or 5.4, both of which are also in the state of not officially supporting Python 3.13 (coming in Celery 5.5).
Safety Assurance
Safety story
kombuis a dependency ofcelery, and not used directly by HQ code. Planning to test on staging.Automated test coverage
Not directly.
Rollback instructions