Fix overflow if history size is integer multiple of entries#13
Open
f-adler wants to merge 2 commits intodimmykar:developfrom
Open
Fix overflow if history size is integer multiple of entries#13f-adler wants to merge 2 commits intodimmykar:developfrom
f-adler wants to merge 2 commits intodimmykar:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great library! I'm really happy with it. However, I came across an edge case which led to a crash in my system.
The issue can be reproduced with the following use case:
Display.Backlight(0),Display.Backlight(1),Display.Backlight(2),Display.Backlight(3).Analysis:
\0being the last byte of the buffer.part0leading to memory overwrites.The proposed code changes fix the error but additional consequences are not entirely clear. Feedback always welcome.
Cheers!
Felix