Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vd/documentation #315

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Vd/documentation #315

merged 10 commits into from
Oct 23, 2023

Conversation

vdebauche
Copy link
Collaborator

Add documentation + description folder utils + name project.toml

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #315 (92b38b2) into master (f8347ad) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files          60       60           
  Lines        4410     4410           
=======================================
  Hits         3653     3653           
  Misses        757      757           
Files Coverage Δ
src/domain/continuous_domain.jl 50.00% <ø> (ø)
src/domain/custom_domain.jl 33.33% <ø> (ø)
src/domain/domain_list.jl 78.00% <ø> (ø)
src/domain/general_domain.jl 60.39% <ø> (ø)
src/domain/grid.jl 69.92% <ø> (ø)
src/optim/abstraction/ellipsoids_abstraction.jl 97.11% <ø> (ø)
src/optim/abstraction/hierarchical_abstraction.jl 93.37% <ø> (ø)
src/optim/abstraction/lazy_abstraction.jl 94.76% <ø> (ø)
...c/optim/abstraction/lazy_ellipsoids_abstraction.jl 83.67% <ø> (ø)
src/optim/abstraction/naive_abstraction.jl 94.40% <ø> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vdebauche
Copy link
Collaborator Author

Where can I see the documentation that has been generated ?

@vdebauche vdebauche requested a review from adrienbanse October 20, 2023 12:48
Copy link
Collaborator

@adrienbanse adrienbanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @vdebauche, crazy job

@@ -1,14 +1,14 @@
# Optim

This folder contains all the different solvers that can be used.
This folder contains all the different (abstraction-based or not) solvers that can be used. Note that all the solvers are defined using the MathOptInterface framework: for each solver, we define the structure [`AbstractOptimizer`](https://jump.dev/MathOptInterface.jl/stable/reference/models/#MathOptInterface.AbstractOptimizer) and implement the [`Optimize!`](https://jump.dev/MathOptInterface.jl/stable/reference/models/#MathOptInterface.optimize!) function.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a subclass of AbstractOptimizer but not an object of this type

@@ -3,23 +3,36 @@
This folder contains different ways to define systems, for instance to encode a controller.

## Control system

Each control system should be implemented as a ControlSystem .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before dot

Dionysos.System.ControlSystem
```

So far, we have implemented a few examples of control systems :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before :

@@ -7,7 +7,7 @@ end
"""
DomainList{N,T,S<:Grid{N,T}}

Struct for a basic domain based on a `Grid`
Struct for a basic domain based on a `Grid` .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before dot

@@ -113,7 +113,7 @@ end
GridEllipsoidalRectangular{N,T} <: Grid{N,T}

Uniform grid on rectangular space `rect`, centered at `orig` and with steps set by the vector `h`.
Cells are (possibly overlapping) ellipsoids defined at each grid point `c` as `(x-c)'P(x-c) ≤ 1`
Cells are (possibly overlapping) ellipsoids defined at each grid point `c` as `(x-c)'P(x-c) ≤ 1` .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before dot

@@ -16,7 +16,7 @@ using HybridSystems
"""
Optimizer{T} <: MOI.AbstractOptimizer

Branch and bound solver
Branch and bound solver : Optimal control of hybrid systems via a predictive control scheme combining a branch and bound algorithm that can refine Q-functions using Lagrangian duality.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before :


is the abstract type which defines a control system.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that" instead of "which"?

@@ -164,7 +170,7 @@ end
"""
SimpleSystem{N, T, F <: Function, F2} <: ControlSystem{N, T}

TO ADD
is one implementation of the `ControlSystem` type
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot missing

@@ -10,7 +10,7 @@ using Polyhedra
DiscreteTrajectory{Q, TT}

`q_0` is the starting mode and `transitions` is a sequence of discrete
transitions in the system
transitions in the system.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove return?

@@ -37,7 +37,7 @@ end
ContinuousTrajectory{T, XVT<:AbstractVector{T}, UVT<:AbstractVector{T}}

`x` is a sequence of points in the state space and `u` is a sequence of points
in the input space
in the input space.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove return?

Virginie Debauche and others added 2 commits October 22, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants