-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vd/documentation #315
Vd/documentation #315
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 60 60
Lines 4410 4410
=======================================
Hits 3653 3653
Misses 757 757
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Where can I see the documentation that has been generated ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @vdebauche, crazy job
docs/src/reference/Optim.md
Outdated
@@ -1,14 +1,14 @@ | |||
# Optim | |||
|
|||
This folder contains all the different solvers that can be used. | |||
This folder contains all the different (abstraction-based or not) solvers that can be used. Note that all the solvers are defined using the MathOptInterface framework: for each solver, we define the structure [`AbstractOptimizer`](https://jump.dev/MathOptInterface.jl/stable/reference/models/#MathOptInterface.AbstractOptimizer) and implement the [`Optimize!`](https://jump.dev/MathOptInterface.jl/stable/reference/models/#MathOptInterface.optimize!) function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a subclass of AbstractOptimizer
but not an object of this type
docs/src/reference/System.md
Outdated
@@ -3,23 +3,36 @@ | |||
This folder contains different ways to define systems, for instance to encode a controller. | |||
|
|||
## Control system | |||
|
|||
Each control system should be implemented as a ControlSystem . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space before dot
docs/src/reference/System.md
Outdated
Dionysos.System.ControlSystem | ||
``` | ||
|
||
So far, we have implemented a few examples of control systems : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space before :
src/domain/domain_list.jl
Outdated
@@ -7,7 +7,7 @@ end | |||
""" | |||
DomainList{N,T,S<:Grid{N,T}} | |||
|
|||
Struct for a basic domain based on a `Grid` | |||
Struct for a basic domain based on a `Grid` . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space before dot
src/domain/grid.jl
Outdated
@@ -113,7 +113,7 @@ end | |||
GridEllipsoidalRectangular{N,T} <: Grid{N,T} | |||
|
|||
Uniform grid on rectangular space `rect`, centered at `orig` and with steps set by the vector `h`. | |||
Cells are (possibly overlapping) ellipsoids defined at each grid point `c` as `(x-c)'P(x-c) ≤ 1` | |||
Cells are (possibly overlapping) ellipsoids defined at each grid point `c` as `(x-c)'P(x-c) ≤ 1` . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space before dot
src/optim/branch_and_bound.jl
Outdated
@@ -16,7 +16,7 @@ using HybridSystems | |||
""" | |||
Optimizer{T} <: MOI.AbstractOptimizer | |||
|
|||
Branch and bound solver | |||
Branch and bound solver : Optimal control of hybrid systems via a predictive control scheme combining a branch and bound algorithm that can refine Q-functions using Lagrangian duality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space before :
src/system/controlsystem.jl
Outdated
|
||
is the abstract type which defines a control system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"that" instead of "which"?
src/system/controlsystem.jl
Outdated
@@ -164,7 +170,7 @@ end | |||
""" | |||
SimpleSystem{N, T, F <: Function, F2} <: ControlSystem{N, T} | |||
|
|||
TO ADD | |||
is one implementation of the `ControlSystem` type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dot missing
src/system/trajectory.jl
Outdated
@@ -10,7 +10,7 @@ using Polyhedra | |||
DiscreteTrajectory{Q, TT} | |||
|
|||
`q_0` is the starting mode and `transitions` is a sequence of discrete | |||
transitions in the system | |||
transitions in the system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove return?
src/system/trajectory.jl
Outdated
@@ -37,7 +37,7 @@ end | |||
ContinuousTrajectory{T, XVT<:AbstractVector{T}, UVT<:AbstractVector{T}} | |||
|
|||
`x` is a sequence of points in the state space and `u` is a sequence of points | |||
in the input space | |||
in the input space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove return?
Add documentation + description folder utils + name project.toml