Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unicycle in the new frame #383

Merged
merged 21 commits into from
Nov 6, 2024
Merged

Adding unicycle in the new frame #383

merged 21 commits into from
Nov 6, 2024

Conversation

johnaoga
Copy link
Collaborator

@johnaoga johnaoga commented Nov 1, 2024

No description provided.

src/MOI_wrapper.jl Outdated Show resolved Hide resolved
@@ -17,7 +17,7 @@ mutable struct Optimizer <: MOI.AbstractOptimizer
variable_index::Vector{Int} # MOI.VariableIndex -> state/input/mode index
lower::Vector{Float64}
upper::Vector{Float64}
start::Vector{Float64}
start::Vector{Union{Float64, MOI.Interval{Float64}}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
start::Vector{Union{Float64, MOI.Interval{Float64}}}
start::Vector{MOI.Interval{Float64}}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should modify set for VariablePrimalStart and create an interval with two equal bounds there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the case where start is only a value, right?

src/MOI_wrapper.jl Outdated Show resolved Hide resolved
@johnaoga
Copy link
Collaborator Author

johnaoga commented Nov 4, 2024

@blegat, do you have any idea why the documentation is failing? It's not clear to me.

@blegat
Copy link
Collaborator

blegat commented Nov 4, 2024

Oops, looks like a bug in JuMP, it should be fixed and released tomorrow or so, we can wait.

@johnaoga
Copy link
Collaborator Author

johnaoga commented Nov 5, 2024

@blegat I rerun but it's doesn't seem to change. Do I have to update the JuMP version in some ways?
I would like to merge this asap tbh!

@blegat
Copy link
Collaborator

blegat commented Nov 5, 2024

What do you think about #386
We have not made any release yet.

@blegat
Copy link
Collaborator

blegat commented Nov 6, 2024

I rerun but it's doesn't seem to change. Do I have to update the JuMP version in some ways?

The PR should turn green with the new commits, I checked out JuMP in the Github action script

@blegat blegat merged commit 63d669d into master Nov 6, 2024
6 checks passed
@blegat blegat mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants