Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements unit tests for orbit conversion utils, fixes obliquity of … #748

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

bernardinelli
Copy link
Collaborator

…the ecliptic value. Also fixes one character in the lightcurve demo notebook

Fixes #680 .

Describe your changes.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9b5cdf) 74.34% compared to head (77c0d26) 74.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
+ Coverage   74.34%   74.54%   +0.19%     
==========================================
  Files          66       66              
  Lines        3025     3025              
==========================================
+ Hits         2249     2255       +6     
+ Misses        776      770       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bernardinelli bernardinelli merged commit f7ae7ae into main Dec 14, 2023
8 of 10 checks passed
@bernardinelli bernardinelli deleted the orbit_test branch December 14, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests of barycentric orbit conversion and ephemeris generation
2 participants