Skip to content

Conversation

@sbland
Copy link
Contributor

@sbland sbland commented Aug 26, 2025

  • Still need to improve tests
  • There is some repetition of data provided in view context
  • REQUIRES DATABASE MIGRATION

Description

Relates to issues #466 and #454 to allow viewing example profiles.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Outstanding tasks

- Still need to improve tests
- There is some repetition of data provided in view context
- REQUIRES DATABASE MIGRATION
@sbland sbland linked an issue Aug 26, 2025 that may be closed by this pull request
3 tasks
@AdrianDAlessandro
Copy link
Collaborator

I haven't looked through this in detail. But a general comment is that this seems like a smart/flexible approach to take. But maybe for the Workshop, we should just hard-code this and not worry about the database at all.

@sbland sbland marked this pull request as draft August 27, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a way of viewing sample profiles.

3 participants