Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/handle create on message create #108

Closed
wants to merge 2 commits into from
Closed

Fix/handle create on message create #108

wants to merge 2 commits into from

Conversation

cm-ayf
Copy link
Contributor

@cm-ayf cm-ayf commented Jun 17, 2024

closes: #106

@cm-ayf cm-ayf requested a review from femshima June 17, 2024 22:58
@cm-ayf cm-ayf self-assigned this Jun 17, 2024
@cm-ayf
Copy link
Contributor Author

cm-ayf commented Jun 17, 2024 •
edited
Loading

ん，ThreadCreate時にstarterが同期的に手に入らなかったらMessageCreateをonceするという別の手も思いついた

それはtiming issueが怖いので，Collectorを使うほうが良いのでは

@cm-ayf
Copy link
Contributor Author

cm-ayf commented Jun 17, 2024

in favor of the comment above and #109

@cm-ayf cm-ayf closed this Jun 17, 2024
@cm-ayf cm-ayf deleted the fix/handle-create-on-message-create branch June 17, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@femshima femshima Awaiting requested review from femshima

Assignees

@cm-ayf cm-ayf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ThreadCreate時点でstarter messageが存在しない場合に処理できない
1 participant
@cm-ayf