-
-
Notifications
You must be signed in to change notification settings - Fork 4k
fix: improve handling of italics in the presence of links #11064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test or tests for this!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11064 +/- ##
==========================================
+ Coverage 44.06% 44.13% +0.06%
==========================================
Files 310 310
Lines 17755 17776 +21
Branches 1755 1760 +5
==========================================
+ Hits 7824 7845 +21
Misses 9919 9919
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added Edit: I forgot to test locally, give me a moment to set up my env |
Patched |
Do you mean that this PR would fail to escape the italics, introducing new problematic behavior? That's fair, I'll see what I can do about that. |
Please describe the changes this PR makes and why it should be merged:
The underscore matcher already has
(?<!<a?:.+|https?:\/\/\S+)
, which prevents escaping underscores in emojis, animated emojis, and links (from the https to the first whitespace character).This PR makes sure asterisks aren't escaped in links either. Fixes #11063.
Status and versioning classification: