Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: hide component on mobile chat pages #54

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

chapoi
Copy link
Contributor

@chapoi chapoi commented Oct 7, 2024

The brand header conflicts with the precarious chat height calculations on mobile, pushing the chat input below the fold and adding unintended scrolling.

This commit hides the component on mobile pages that have the has-full-page-chat class.

Copy link

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐥

@chapoi chapoi merged commit 18962bb into main Oct 7, 2024
4 checks passed
@chapoi chapoi deleted the hide-on-chat-mobile-pages branch October 7, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants