FIX: Ensure that custom header links migration do not fail validation #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
commented
Apr 25, 2024
| @@ -21,6 +21,7 @@ custom_header_links: | |||
| hide_on_scroll: "keep" | |||
| schema: | |||
| name: "link" | |||
| identifier: text | |||
There was a problem hiding this comment.
Sneaking this UX change in here.
tgxworld
force-pushed
the
make_title_optional
branch
2 times, most recently
from
f238271 to
4cbc44b
Compare
tgxworld
force-pushed
the
make_title_optional
branch
2 times, most recently
from
e0a4592 to
883f800
Compare
tgxworld
commented
Apr 26, 2024
| view: "vdm" | ||
| target: "self" | ||
| hide_on_scroll: "keep" | ||
| default: [] |
There was a problem hiding this comment.
Remove the default since we no longer need to provide examples of the format of the setting.
This commit is a follow up to 7374793 where the migration will fail because the objects created by the migration will end up failing to save because the objects will fail the validation given the new schema. This commit updates the migration to ensure that we do not end up with invalid objects.
tgxworld
force-pushed
the
make_title_optional
branch
from
883f800 to
b9a7773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a follow up to 7374793 where the migration will fail because the objects created by the migration will end up failing to save because the objects will fail the validation given the new schema. This commit updates the migration to ensure that we do not end up with invalid objects.