DEV: add deprecation id from DeprecatedOutletArgument #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
force-pushed
the
dev-add-plugin-outlet-arg-deprecation
branch
from
20999c6 to
b111f49
Compare
tgxworld
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a way to mark plugin outlet arguments as deprecated (discourse/discourse#27885) and the current automated way of capturing deprecation IDs does not yet include these.
Adding the IDs manually for now directly into DeprecationCollector::List (and we can continue to use that array literal for adding other IDs that aren't properly captured by the script) - https://github.com/search?q=org%3Adiscourse+deprecatedOutletArgument&type=code is a simple way to search for these deprecated plugin outlet args.