Update Discourse Core Deprecations #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tyb-talks
requested changes
Jan 14, 2025
github-actions
bot
force-pushed
the
update-discourse-core-deprecations
branch
from
dec6c88 to
eefa9f6
Compare
|
Entries in the files to debug were triggered as we were referencing Will need to think further on how properly exclude these entries from future workflow runs. We don't want to whitelist the file names, as that blanket removes parsing of other deprecation IDs from those files, so maybe we could add some whitelisting logic on the exported constant. 🤔 |
tyb-talks
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the list of Discourse deprecations in the
deprecation-ids.ymlfile.The
files_to_debug.txtfile contains paths of files that should be checked for deprecation IDs thatwere not found by the script. Please remove those entries (but not the file) before merging.