FIX: /login loop when categories is default homepage #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renato
force-pushed
the
fix_login_loop
branch
from
f1dbac7
to
7ff9fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/loginis going into an infinite loop if the categories list is set as default homepage.This PR fixes it by not aborting the current transition and only redirecting on the
nextcycle.It also fixes a test failure that has been happening for ~2 months.
For reference, the removed
transition.abort()call was probably intended as a workaround for this (still open) Ember issue: emberjs/ember.js#18577