DEV: Use backend plugin api instead of frontend apis to override translation values #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests will fail until discourse/discourse#31261 is merged. |
|
Will add discourse-compat |
nattsw
commented
Feb 14, 2025
| @@ -1,4 +1,4 @@ | |||
| < 3.5.0.beta1-dev: f7d6ca6b32c0cff27422dd9f7583f41b203c0c57 | |||
| < 3.5.0.beta1-dev: 65d7ea2dbc9e7bf276e5ac3f9e23c2111e64e278 | |||
There was a problem hiding this comment.
Version required is discourse/discourse@5f00ae2, parent is discourse/discourse@65d7ea2
lis2
reviewed
Feb 14, 2025
lis2
reviewed
Feb 14, 2025
lis2
reviewed
Feb 14, 2025
lis2
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #205, we returned translated values using existing JS apis. While this was convenient, it does not allow us to modify crawler views such as ...
https://github.com/discourse/discourse/blob/main/app/views/topics/show.html.erb
... when we want to serve translated pages.
This PR makes use of discourse/discourse#31261 to override the values.