PERF: Avoid allocating array in MiniScheduler::Manager.discover_queues
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`map(&:queue).to_set` is inefficient because it creates an array before converting the array to a set. Instead, we can just iterate and add the values to the set to avoid allocating the array completely. This is beneficial when there are many `MiniScheduler::Schedule` objects.
nattsw
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map(&:queue).to_setis inefficient because it creates an array beforeconverting the array to a set. Instead, we can just iterate and add the
values to the set to avoid allocating the array completely. This is
beneficial when there are many
MiniScheduler::Scheduleobjects.