Require the main prometheus_exporter module in client and server modules #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main module includes some consts and defaults, which both client and server require to work. In the README, it is suggested to treat client and server modules as entry-points, but without requiring the main module they won't work. In this commit, I'm adding a require and tests to show the problem.
Ruto8
force-pushed
the
pr-fix-requires
branch
from
057b4c2 to
5265372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main module includes some consts and defaults, which both client and server require to work. In the README, it is suggested to treat client and server modules as entry-points, but without requiring the main module they won't work.
In this commit, I'm adding a require and tests to show the problem.
The error we experience with simply requiring a client is the following
I considered removing the require from the test helper, but I figured these new tests make more sense and will be more stable (just so there's some independence and reliable require order)