Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose - Reorganize Nets #66

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

GabrielBG0
Copy link
Collaborator

@GabrielBG0 GabrielBG0 commented Jun 29, 2024

Reorganize nets to be contained by the architecture to prevent too many files.

  • Files that had "cnn" on the name went to cnn.py and sfm went to vit.py since it is just a variation of it.
  • Deleting some commented code and unused imports

@GabrielBG0 GabrielBG0 requested a review from otavioon June 29, 2024 04:15
@GabrielBG0
Copy link
Collaborator Author

GabrielBG0 commented Jun 29, 2024

I'm down to separate nets by use too e.g. image, text, time series, etc...

Copy link
Collaborator

@otavioon otavioon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@otavioon
Copy link
Collaborator

otavioon commented Jul 2, 2024

I'm down to separate nets by use too e.g. image, text, time series, etc...

I agree. Should you make in this PR or another one?

@GabrielBG0
Copy link
Collaborator Author

Gonna make another one just to be more organized

@GabrielBG0 GabrielBG0 merged commit 4c6e199 into discovery-unicamp:main Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants