DGIR-44 : Update hook for cascading Entity Status #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bibliophileaxe
requested changes
Nov 22, 2023
islandora_entity_status.module
Outdated
| */ | ||
| function islandora_entity_status_entity_update(EntityInterface $entity) { | ||
| // Check if the entity is a node with the bundle "islandora_object". | ||
| if ($entity->getEntityTypeId() == 'node' && $entity->bundle() == 'islandora_object') { |
There was a problem hiding this comment.
Instead of this check, check if entity has field IslandoraUtils::MEDIA_OF_FIELD
There was a problem hiding this comment.
We can not validate IslandoraUtils::MEDIA_OF_FIELD as its not present in islandora_object content type.
There was a problem hiding this comment.
Checking for MEMBER_OF_FIELD field.
islandora_entity_status.module
Outdated
| /** | ||
| * Implements hook_entity_update(). | ||
| */ | ||
| function islandora_entity_status_entity_update(EntityInterface $entity) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
hook change from hook_entity_update to hook_ENTITY_TYPE_update
bibliophileaxe
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.