June 27: More preset updates #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new split sigil for earth + torment with a sketchy rough approximation of proc rates
Unrelenting Criticism is now a trait powerful enough to make 8 page FB a thing of the past. This comments out the template while leaving the presets just in case.
Funnily enough, all the uptime values one would expect to change were exactly the same in this log
This reverts commit ff11a72.
Co-Authored-By: James Hobin <hobinjk@gmail.com>
|
Our documentation is bad on this—should be a comment in the file—but note that the purpose of the schema dictionary file is that @gw2princeps' URL sharing compression code uses it to translate IDs to numerical indices and back according to the order in these arrays, and thus new entries must go at the end to preserve the index values of all previous entries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.