Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add mismatched ascended trinkets #581

Merged
merged 7 commits into from
Aug 5, 2023

Conversation

marcustyphoon
Copy link
Collaborator

requires affix.rs update, I think?

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e14e501
Status: ✅  Deploy successful!
Preview URL: https://27af50c8.discretize-optimizer.pages.dev
Branch Preview URL: https://mismatched-ascended-trinkets.discretize-optimizer.pages.dev

View logs

@gw2princeps
Copy link
Member

requires affix.rs update, I think?

yeah, I'll take a look at it at some point

@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Aug 5, 2023

Ah. You can't put spaces in a Rust identifier. That seemed like a bad idea in the first place, to be fair... but, I don't know what the best thing to do is so that the AffixesSelect component displays the correct name. I could use underscores.

What we really need to do is to decide what the prop input for CreateItem should be for these and then use that everywhere for consistency.

Edit: I see a 'berserkerandvalkyrie' when I search gw2-ui.

@marcustyphoon
Copy link
Collaborator Author

So:

Berserker and Valkyrie: Breaks Rust core unless we add more hacks (spaces are not allowed in Rust identifiers)
Berserker_and_Valkyrie: Breaks my cleanupLocale script (underscores indicate invalid parts of translated strings)
berserkerandvalkyrie, berserkervalkyrie: Cannot be processed back into individual words
BerserkerAndValkyrie: Works, but looks weird in results (we pass unmodified strings to <Character>

Fun.

@marcustyphoon marcustyphoon merged commit 86bba33 into staging Aug 5, 2023
@marcustyphoon marcustyphoon deleted the mismatched-ascended-trinkets branch August 5, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants