Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo check rust action #583

Merged
merged 6 commits into from
Sep 9, 2023
Merged

Add cargo check rust action #583

merged 6 commits into from
Sep 9, 2023

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Aug 5, 2023

This adds a github action that runs the Rust linter on the Rust module, including tests/benches. (I didn't check if warnings make the action report success or failure; will have to test that).

Note that apparently the [lints] entry in Cargo.toml, similar to an eslint config in package.json, is not yet available in stable Rust: https://www.reddit.com/r/rust/comments/13re6rr/you_can_specify_lints_with_lints_table_in/

Thus, it looks like the best way to turn off rules at the moment is via #![allow(rulename)] at the top of lib.rs.

  • Make this succeed

[no previews]

@github-actions github-actions bot requested a deployment to preview (cargo-check) September 9, 2023 23:11 In progress
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ce41f35
Status: ✅  Deploy successful!
Preview URL: https://fe8712aa.discretize-optimizer.pages.dev
Branch Preview URL: https://cargo-check.discretize-optimizer.pages.dev

View logs

This reverts commit d9926d8.
@marcustyphoon
Copy link
Collaborator Author

apparently I have to merge this to get the action to run to test it!

@marcustyphoon marcustyphoon merged commit 1f725d2 into staging Sep 9, 2023
2 checks passed
@marcustyphoon marcustyphoon deleted the cargo-check branch September 9, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant