Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use cloudflare/wrangler-action in deploy #795

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Sep 14, 2024

cloudflare/pages-action appears to be abandoned (without a note in the readme! I am not impressed by the state of your tooling, cloudflare!), so I think we'll eventually have to do this. cloudflare/wrangler-action currently does not create github deployments, to my knowledge, however, so I'm happy to wait.

See cloudflare/pages-action#117 and cloudflare/wrangler-action#274.

  • check if there are new/different action outputs to improve the PR comment

[draft previews]

Copy link
Contributor

github-actions bot commented Sep 14, 2024

Deployed build to Cloudflare!

Last commit: 36bceb3
Preview URL: https://04705898.discretize-gear-optimizer.pages.dev
Branch Preview URL: https://wrangler-action.discretize-gear-optimizer.pages.dev

@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Nov 27, 2024

cloudflare/wrangler-action#325 was shipped but I'm not sure it... worked? I see no action summary from this PR. Anyway, it noted more improvements to come in the future, which included changing the preference API again, so may as well wait for that.

@marcustyphoon marcustyphoon changed the title Chore: Use cloudflare/wrangler-action in deploy chore: Use cloudflare/wrangler-action in deploy Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant