Feat: Implement stop button in multicore mode #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed preview build to Cloudflare!
|
marcustyphoon
force-pushed
the
stop-rust-2
branch
from
d16c2e6
to
f48bdb1
Compare
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the stop calculation button, but not the resume button, in the multicore rust mode.
It stops the calculation by terminating the active workers from the main thread and creating new ones. This obviously isn't as elegant as having the Rust code actually pause and let handlers run to check if it's received a message every so often (probably doable with
wasm_bindgen_futuresor whatever), but I don't know how to do that and this is at least better than having to refresh the page and lose your whole state.