Fix: Inconsistent combination ids in heuristics mode #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed preview build to Cloudflare!
|
marcustyphoon
force-pushed
the
heuristics-consistent-ids
branch
from
f21164c
to
8615df4
Compare
marcustyphoon
force-pushed
the
heuristics-consistent-ids
branch
from
8615df4
to
3e88794
Compare
marcustyphoon
force-pushed
the
heuristics-consistent-ids
branch
from
3e88794
to
35fac85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baby's first nontrivial Rust code; yes I will get around to learning the language for real some time, no today is not that day. Not AI-assisted—I hate using AI for code in its current state—but I was copy-pasting out of docs examples, so it arguably may as well be.
Anyway: this, for compatibility with #796, ensures that
character.combination_idwill refer to the index of the relevant combination relative to the entire combination list, not to the list picked by heuristics, by usingpicked_combination_idsas a whitelist instead of filtering the array with it beforehand.Resolves #798.