Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding existing docs to the wiki #1

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

vaporvee
Copy link

@vaporvee vaporvee commented May 2, 2024

No description provided.

@vaporvee vaporvee marked this pull request as draft May 2, 2024 18:57
@vaporvee
Copy link
Author

vaporvee commented May 3, 2024

if you need me to squash some changes or anything just lmk

@topi314
Copy link
Member

topi314 commented May 3, 2024

I am gonna squash it anyway in the end

@vaporvee
Copy link
Author

vaporvee commented May 3, 2024

maybe merge that first after i change anything else because all the existing docs i found are in there. I'll add additional docs after that

@vaporvee vaporvee changed the title Generally adding more info to the wiki Adding existing docs to the wiki May 3, 2024
@vaporvee vaporvee marked this pull request as ready for review May 3, 2024 17:31
Copy link
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial thoughts, I am not sure how much sense it makes to list all methods & types in here when https://pkg.go.dev/ exists

instead I think this should rather be filled with info besides types maybe?

logo_title.onclick = function() {
location.href = document.location.origin;
};
logo_title.onmouseover = function(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant you do this with css? lol

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah was in my js file forgot about it lmao

Comment on lines +10 to +14
## **More information**
Documentation is still under construction so you may consider also looking at these:

[![Go Reference](https://pkg.go.dev/badge/github.com/disgoorg/disgo.svg)](https://pkg.go.dev/github.com/disgoorg/disgo) <br>
[![Discord Documentation](https://img.shields.io/badge/Discord%20Documentation-blue.svg)](https://discord.com/developers/docs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I don't dislike these changes can you partially revert these?
the new info isn't bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants