Define unknownFieldRetention trait #135
Conversation
| .build() | ||
|
|
||
| val model = | ||
| Model.assembler.disableValidation |
There was a problem hiding this comment.
any reason why we have to disable validation?
There was a problem hiding this comment.
Not sure, I based this spec on one of the existing ones which had this. I'll see what happens if I enable it.
dhpiggott
force-pushed
the
define-unknown-field-retention-trait
branch
from
4417d9e to
739f418
Compare
dhpiggott
force-pushed
the
define-unknown-field-retention-trait
branch
from
739f418 to
a741ba6
Compare
| @trait( | ||
| selector: "structure > member :test(> document)" | ||
| ) | ||
| structure unknownJsonFieldRetention {} |
There was a problem hiding this comment.
From @Baccata via Slack:
just unify the two traits as jsonUnkown. Document abides by json semantics, and we do implement the same semantics in both Document and jsoniter
|
@lewisjkl GitHub told me you merged this but it also tells me that #180 replaced it. So wondering if you meant to merge this and if so how the two relate. I see:
But then I see nothing on main 🤔 Bit confused! |
|
Ben's PR forked from your branch, and had all the commits your branched contained. So merging Ben's PR into main implies merging this PR into main, as all the commits end up in main. |
|
Aaaah, thanks! I should have looked at #180 more carefully, then I'd have realised. |
No description provided.