-
Notifications
You must be signed in to change notification settings - Fork 19
feat: Species node #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Species node #2271
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
52a8568
Initial BROKEN Species Node
rprospero c61e51e
Successfully parse a species
rprospero 3e7687a
Move to passing Species directly to the Node
rprospero 384f64f
Add species to GUI menu
rprospero 14d5bde
Eliminate keyword widgets
rprospero 38ddd98
Start showing species data in gui
rprospero 972b5b9
Start creating species dialog
rprospero 3bb3e41
Start displaying all species information
rprospero 6426b76
Display atom type information
rprospero d1f2087
Add Element Combo Box
rprospero ed91049
Fix bug where nodes don't export options
rprospero 329dc89
Start moving to immutable species
rprospero 1ee2ec0
Test on SpeciesModel instead of SpeciesNode
rprospero 6614631
Switch to shared_ptr
rprospero 7eab1d6
Ensure that species is serialised
rprospero 43a8bbf
Statr validating atom input
rprospero 265990e
Start adding bond info to species dialog
rprospero e402383
Add Species Node icon
rprospero 53d5e7e
Better finish on Bond model
rprospero a63fb40
Move add button to end of tab order
rprospero c3fa023
Better implicit widths
rprospero d57abf1
Add angle to model
rprospero 48b3ae1
Add torsions to species model
rprospero 0dc8bc3
Add impropers to species model
rprospero f00551e
Include atom type in species
rprospero cd50416
Fix loading species
rprospero 181b12f
More comprehensive testing of SpeciesModel
rprospero 05b2ba7
Fix formatting
rprospero d4f9b3d
Fixup from personal review
rprospero 1abf327
Deactivate last bits of old GUI
rprospero d00006e
No special windows build for keywordWidgets
rprospero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we expect problems if
atomType_is null? It seems like in that case, the "type" key-value pair oftarget[tag]will be missing, which we may well need to catch somewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
atomType_is optional in the SpeciesAtom and line 499 (in thedeserialise) method handles with case by checking for the "type" tag withoptionalOn. That way, if the "type" tag is missing, theatomType_is null.