Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: http example #38

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: http example #38

merged 1 commit into from
Oct 17, 2024

Conversation

bluebrown
Copy link
Contributor

Remove the superfluous response.WriteHeader call.

https://pkg.go.dev/net/http#ResponseWriter:

If [ResponseWriter.WriteHeader] has not yet been called, Write calls
WriteHeader(http.StatusOK) before writing the data.

@bluebrown
fix: http example
7193c36 
Remove the superfluous response.WriteHeader call.

https://pkg.go.dev/net/http#ResponseWriter:
> If [ResponseWriter.WriteHeader] has not yet been called, Write calls
> WriteHeader(http.StatusOK) before writing the data.

Signed-off-by: bluebrown <rainbowstack@gmail.com>
achille-roussel
achille-roussel approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@achille-roussel achille-roussel merged commit fc22d41 into dispatchrun:main Oct 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achille-roussel achille-roussel achille-roussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluebrown @achille-roussel