Skip to content

Acceptance of query types in required arguments#6

Open
JustAdam wants to merge 11 commits intodisqus:masterfrom
allermedia:master
Open

Acceptance of query types in required arguments#6
JustAdam wants to merge 11 commits intodisqus:masterfrom
allermedia:master

Conversation

@JustAdam
Copy link

@JustAdam JustAdam commented Apr 8, 2011

So now you can use:

$data = array('forum' => 'forum_name', 'thread:ident' => 'ident');

json configuration feels a little clunky, but does its job.

"details": {
"required": [
"thread"
],
"query_type": {
"requires": "forum",
"insteadof": "thread",
"with_either": ["thread:ident", "thread:link" ]
},
"method": "GET",
"formats": [
"json",
"jsonp"
]
},

I have only updated the configuration for the threads commands (not sure if anything else is missing).

@dcramer
Copy link
Contributor

dcramer commented Apr 11, 2011

Going to discuss this over internally, as right now query types are sort of a hack. The current interface.json implementation is actually able to be auto generated, and we'll need to add support for query types proper so that they can be included in that to do a release.

@brianlmoon
Copy link

Yeah, I had to hack it to do this as well. My hack is a little less involved.

@JustAdam
Copy link
Author

JustAdam commented Nov 4, 2011

I think that last commit should probably of been patched against a fresh fork ... let me know if you need it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants