Acceptance of query types in required arguments#6
Open
JustAdam wants to merge 11 commits intodisqus:masterfrom
allermedia:master
Open
Acceptance of query types in required arguments#6JustAdam wants to merge 11 commits intodisqus:masterfrom allermedia:master
JustAdam wants to merge 11 commits intodisqus:masterfrom
allermedia:master
Conversation
Contributor
|
Going to discuss this over internally, as right now query types are sort of a hack. The current interface.json implementation is actually able to be auto generated, and we'll need to add support for query types proper so that they can be included in that to do a release. |
|
Yeah, I had to hack it to do this as well. My hack is a little less involved. |
Author
|
I think that last commit should probably of been patched against a fresh fork ... let me know if you need it done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So now you can use:
$data = array('forum' => 'forum_name', 'thread:ident' => 'ident');
json configuration feels a little clunky, but does its job.
"details": {
"required": [
"thread"
],
"query_type": {
"requires": "forum",
"insteadof": "thread",
"with_either": ["thread:ident", "thread:link" ]
},
"method": "GET",
"formats": [
"json",
"jsonp"
]
},
I have only updated the configuration for the threads commands (not sure if anything else is missing).