Added support for Elasticsearch 8 #458
Conversation
The cause for the actions failing is because python2.7 support was removed from Actions some time around June. You could push this as well along in this PR or just make these changes - oehrlein#5 |
|
Thanks @oehrlein for the PR. I need to test it locally with ES 8. Have you tested it locally? |
|
@DarkAbhi All the other Python versions are failing as well. I've toyed around with it for a bit and it has to do with the security settings that come with Elasticsearch 8, namely the security certificate. Regarding Python 2.7 not being supported by GitHub actions, I did see that as well, but didn't want to remove that in this PR since I think it'd be more fitting to remove it in a separate PR. |
|
@safwanrahman No problem, and I have! All the tests pass for me. |
We need to wait for django-es/django-elasticsearch-dsl#458 or #10730. There are no breaking changes in the API, so this can be deployed without any downtime. The only change is that it now has authentication enabled by default, so our docker image now uses a password. How to deploy: - Deploy web extra - The new packages will continue working with the old ES, but we can make sure by searching from web-extra. - Finish the deploy - Upgrade the ES cluster from cloud.elastic.co
|
@oehrlein @safwanrahman would it be possible to open a new branch for 7.x and merge this pr on main with oehrlein#6 ? |
|
There are some fixes that need to be done in Github CI to pass the tests in CI. I think this PR is ready to go! |
* Upgrade ES to 8.x We need to wait for django-es/django-elasticsearch-dsl#458 or #10730. There are no breaking changes in the API, so this can be deployed without any downtime. The only change is that it now has authentication enabled by default, so our docker image now uses a password. How to deploy: - Deploy web extra - The new packages will continue working with the old ES, but we can make sure by searching from web-extra. - Finish the deploy - Upgrade the ES cluster from cloud.elastic.co * Forgot about this * Fix tests * Upgrade dependencies
I've made changes so Elasticsearch 8 works with this package.
The big caveat here is that testing via GitHub actions fail, but they run without error locally. If anyone could help get that fixed, that would be greatly appreciated as I don't have much experience with Github actions.