Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to change mount point #256

Open
wants to merge 1 commit into
base: next-generation
Choose a base branch
from
Open

Add ability to change mount point #256

wants to merge 1 commit into from

Conversation

Pareder
Copy link

@Pareder Pareder commented Oct 6, 2020

@Pareder Pareder requested a review from legendar October 7, 2020 08:48
@Pareder Pareder self-assigned this Oct 7, 2020
legendar
legendar reviewed Oct 8, 2020
View reviewed changes
.env.default
@@ -1,3 +1,7 @@
# The base URL for all locations
BASE_PATH=/
BASE_URL=$BASE_PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have PUBLIC_PATH and PUBLIC_URL variables.
how can we reuse it ? we need to think about it

Copy link
Author

@Pareder Pareder Oct 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to get all symbols before the last slash in PUBLIC_URL variable? Cause this variable is used for assets folder and looks like /assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendar legendar legendar left review comments

Assignees

@Pareder Pareder

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pareder @legendar