Add toast component to show information to user #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herra
force-pushed
the
feature/add-toast-to-notify-user
branch
from
c2a163b to
ef18c2b
Compare
herra
changed the title
groupsky
approved these changes
May 29, 2020
groupsky
left a comment
groupsky
left a comment
There was a problem hiding this comment.
It's an improvement over the existing alert.
| @@ -1,4 +1,5 @@ | |||
| <div class="container"> | |||
| <toast-component></toast-component> | |||
There was a problem hiding this comment.
If moved to the bottom would implicitly get higher z-index
Comment on lines
50
to
51
| this.toast.classList.add('hide') | ||
| this.toast.classList.remove('show') |
There was a problem hiding this comment.
Duplicated in 3 places - better to extract as a method
Comment on lines
37
to
39
| const toastTitle = this.shadowRoot.querySelector('#title') | ||
| const toastMessage = this.shadowRoot.querySelector('#message') | ||
| const toastTimestamp = this.shadowRoot.querySelector('#time') |
Co-authored-by: Geno Roupsky <geno@roupsky.name>
|
This pull request introduces 1 alert when merging 4048dc1 into 8012a85 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.