Feature/switch to get methods #52
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 2 alerts when merging 5788853 into bbe3317 - view on LGTM.com fixed alerts:
|
groupsky
suggested changes
May 29, 2020
groupsky
left a comment
groupsky
left a comment
There was a problem hiding this comment.
It is a bad idea to use GET for operations that are modifying - caching can prevent the request to reach server and goes against the implicit meaning of http verbs
Contributor
|
I would also prefer GET instead of POST. here is no body content, so whats the purpose of POST? lternatively DELETE would fit, all those requests remove some resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change made because of django csrf validation