Fix variable scoping error in post-smoothing spline processing #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Mattson <jsmattsonjr@gmail.com>
Remove erroneous 'my' declaration that was shadowing the existing $points variable, preventing the spline processing result from being properly passed to subsequent operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Jim Mattson <jsmattsonjr@gmail.com>
Changed incorrect variable $i1 to $i2 in modulo operation for loop index handling. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Jim Mattson <jsmattsonjr@gmail.com>
Remove space in "$ sdir" variable reference. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Jim Mattson <jsmattsonjr@gmail.com>
Fixed cut-and-paste error where $fin filehandle was being closed instead of $fjoin when processing joined files. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Jim Mattson <jsmattsonjr@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
Changed `push @pnew, \%$p;` to `push @pnew, $p;` since $p is already a hash reference. The original syntax was attempting to take a reference to a dereferenced hash. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Jim Mattson <jsmattsonjr@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
Changed "non-poisitive" to "non-positive" in the error message for invalid repeats parameter. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Jim Mattson <jsmattsonjr@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
Added missing 'iLoop' label to 'next' statement for consistency with other control flow statements in the function. This ensures the next statement affects the correct loop level. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Jim Mattson <jsmattsonjr@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
In the line segment optimization logic, when shortening from the beginning of the segment, the code should update $i (start index) not $j (end index). Changed $j = $k to $i = $k to match the intended logic of moving the start point forward. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Jim Mattson <jsmattsonjr@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
djconnel
approved these changes
Sep 7, 2025
Owner
djconnel
left a comment
djconnel
left a comment
There was a problem hiding this comment.
fixed in version 0.54 as well
djconnel
approved these changes
Sep 7, 2025
djconnel
approved these changes
Sep 8, 2025
djconnel
approved these changes
Sep 8, 2025
djconnel
approved these changes
Sep 8, 2025
djconnel
approved these changes
Sep 8, 2025
djconnel
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove erroneous 'my' declaration that was shadowing the existing $points variable, preventing the spline processing result from being properly passed to subsequent operations.
🤖 Generated with Claude Code