Bevy 0.15 support #138
Bevy 0.15 support #138
Conversation
src/plugin.rs
Outdated
| /// [`Transform`]: https://docs.rs/bevy/0.12.0/bevy/transform/components/struct.Transform.html | ||
| /// [`Text`]: https://docs.rs/bevy/0.12.0/bevy/text/struct.Text.html | ||
| /// [`Style`]: https://docs.rs/bevy/0.12.0/bevy/ui/struct.Style.html | ||
| /// [`Node`]: https://docs.rs/bevy/0.15.0/bevy/ui/struct.Node.html | ||
| /// [`Sprite`]: https://docs.rs/bevy/0.12.0/bevy/sprite/struct.Sprite.html | ||
| /// [`ColorMaterial`]: https://docs.rs/bevy/0.12.0/bevy/sprite/struct.ColorMaterial.html |
There was a problem hiding this comment.
Maybe these links should point to latest docs? And also I think Text should be swapped for TextColor here too.
There was a problem hiding this comment.
No they shouldn't. If they point to latest, then when you look at the docs for version N you get a link to the latest version, which is only N until N+1 is published, and will after that forever be wrong.
| @@ -168,7 +165,7 @@ Asset animation always requires the `bevy_asset` feature. | |||
|
|
|||
There was a problem hiding this comment.
I can't comment above this but in L155 Style should be replaced with Node and in L157 Text with TextColor probably?
| @@ -446,7 +446,7 @@ impl<T: 'static> Tween<T> { | |||
| /// # Example | |||
| /// ``` | |||
| /// # use bevy_tweening::{lens::*, *}; | |||
| /// # use bevy::math::*; | |||
| /// # use bevy::math::{*,curve::EaseFunction}; | |||
There was a problem hiding this comment.
Could you please format all these doc changes (i.e. adding a space after each comma, etc.)?
|
@mnmaita Thank you for your code review |
There was a problem hiding this comment.
Thanks for the comprehensive PR. I'll try to review in details when I have more time, likely later this week or on the week-end, but it seems it's chewing a lot. There's the upgrade, and then there's unrelated things like adding a prelude (I think?), changing the easing functions, etc. In general I'd prefer to get standalone PRs for each bit, that not only makes it easier to review, but also makes it easier to bisect bugs in the future and potentially revert changes.
|
OK, I'll split them later. |
|
But isn't EaseFunction considered included in the range of 0.15? |
|
In places like this, use bevy::prelude::*;
use bevy_tweening::{lens::*, *};bevy::prelude::* exports bevy's EaseFunction, and then bevy_tweening::{lens::*, *} also exports interpolation's EaseFunction, and this happens in many places, and in the documentation, making it very cumbersome to modify. And I thought this was part of the migration to 0.15? |
|
Need to add |
|
@rendaoer |
|
Yeah, but it's more idiomatic to have a prelude ( |
|
@musjj ah sorry I thought you were talking about the symbol conflict on |
The main content is to support Bevy 0.15, switch from Style to Node, use TextColor for Text, etc., Migrating from the interpolation library to Bevy, modify the Bundle part of the example, check and optimize the code and documents