Add EmptyView #18
Closed
Add EmptyView #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zzzarya
commented
Apr 20, 2023
•
zzzarya
commented
- Создана EmptyView
- Вместо картинки оставил емоджи папки. Поменяю, если предложите картинку)), я не смог пока придумать какую
Closed
SShliakhin
requested changes
Apr 20, 2023
Comment on lines
+11
to
+12
| private lazy var emptyPictureLabel = makeEmptyPictureLabel() | ||
| private lazy var emptyTextLabel = makeEmptyTextLabel() |
There was a problem hiding this comment.
по структуре все гуд, как я хочу ленивый элемент = функция make из расширения
- наименование можно проще - опционал
- нужна картинка!
| stackContainer.axis = .vertical | ||
| stackContainer.distribution = .fill | ||
| stackContainer.alignment = .center | ||
| stackContainer.spacing = 16 |
There was a problem hiding this comment.
spacing надо использовать из Theme
stackContainer.spacing = Theme.spacing(usage: .standard2)
мой косяк дал пример, а сам в нем не избавился от магический цифр
Comment on lines
+67
to
+70
| top: 0, | ||
| left: 16, | ||
| bottom: 16, | ||
| right: 16 |
| func makeEmptyTextLabel() -> UILabel { | ||
| let label = UILabel() | ||
| label.textColor = Theme.color(usage: .gray) | ||
| label.text = "Empty folder" |
There was a problem hiding this comment.
если используешь внутренний текст (объявлен внутри класса), то используй такой вариант:
// MARK: - Appearance
private extension AboutViewController {
enum Appearance {
static let welcomeText = "Welcome to About"
static let title = "About"
}
}и используй как label.text = Appearance.welcomeText
There was a problem hiding this comment.
Но этого тебе здесь не надо, нам нужна вьюха, которая принимает картинку и текст.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.