-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emptyVIew V3 #30
Merged
Merged
Add emptyVIew V3 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SShliakhin
approved these changes
Apr 23, 2023
Closed
djud17
pushed a commit
that referenced
this pull request
Apr 25, 2023
djud17
added a commit
that referenced
this pull request
Apr 25, 2023
* Tech/2 swift gen (#6) * feat: add Localization files * feat: add SwiftGen * feat: add images (#15) * Add collection of files * feat: add localizable string * feat: add section manager * feat: add collectionView extension * feat: add menuItem cell * feat: add recentFile cell * feat: add main view * refactor: edits based on comments * refactor: MainView * refactor: MainViewController * refactor: Apply comments from review * FilesStorageProvider service (#27) * feat: add FilesStorageProvider service * feat: add dependencies property * fix: make private capacity of recentFilesArray * fix: make dependencies available for module factory * docs: doc IFilesStorageProvider * Revert "FilesStorageProvider service (#27)" (#28) This reverts commit c1b97c0. * FilesStorageProvider v2 (#29) * feat: add FilesStorageProvider service * fix: remove useless properties * feat: add dependencies property * Add emptyView V3 (#30) * feat: create about.md file (#31) * feat: create about.md file * fix: add about.file. Previous commit did not include it * fix: add team leader stub * fix: relocate 'About.md' to assets * fix: remove 'About.md' from 'Modules' folder * fix: Di injection --------- Co-authored-by: Sergei Shliakhin <71236551+SShliakhin@users.noreply.github.com> Co-authored-by: Anton Zarichny <antonzarichny@gmail.com> Co-authored-by: Anton Zarichny <109965569+zzzarya@users.noreply.github.com> Co-authored-by: Dmitry Churilov <98746743+chuRealOff@users.noreply.github.com>
djud17
added a commit
that referenced
this pull request
Apr 25, 2023
commit 753d505 Author: David Tonoyan <davidtonoyan10@me.com> Date: Tue Apr 25 22:52:45 2023 +0400 fix: Di injection commit 75494fc Author: Dmitry Churilov <98746743+chuRealOff@users.noreply.github.com> Date: Tue Apr 25 15:01:11 2023 +0300 feat: create about.md file (#31) * feat: create about.md file * fix: add about.file. Previous commit did not include it * fix: add team leader stub * fix: relocate 'About.md' to assets * fix: remove 'About.md' from 'Modules' folder commit 48d1b07 Author: Anton Zarichny <109965569+zzzarya@users.noreply.github.com> Date: Sun Apr 23 16:39:20 2023 +0300 Add emptyView V3 (#30) commit c2b81da Author: Sergei Shliakhin <71236551+SShliakhin@users.noreply.github.com> Date: Sun Apr 23 15:45:58 2023 +0300 FilesStorageProvider v2 (#29) * feat: add FilesStorageProvider service * fix: remove useless properties * feat: add dependencies property commit 5329e70 Author: Sergei Shliakhin <71236551+SShliakhin@users.noreply.github.com> Date: Sun Apr 23 02:37:02 2023 +0300 Revert "FilesStorageProvider service (#27)" (#28) This reverts commit c1b97c0. commit 05463a5 Author: Sergei Shliakhin <71236551+SShliakhin@users.noreply.github.com> Date: Sun Apr 23 00:08:26 2023 +0300 FilesStorageProvider service (#27) * feat: add FilesStorageProvider service * feat: add dependencies property * fix: make private capacity of recentFilesArray * fix: make dependencies available for module factory * docs: doc IFilesStorageProvider commit a31aea3 Author: David Tonoyan <davidtonoyan10@me.com> Date: Tue Apr 25 22:41:43 2023 +0400 refactor: Apply comments from review commit d0ce0f3 Author: David Tonoyan <davidtonoyan10@me.com> Date: Mon Apr 24 21:32:42 2023 +0400 refactor: MainViewController commit 4d0ba14 Author: David Tonoyan <davidtonoyan10@me.com> Date: Mon Apr 24 21:14:56 2023 +0400 refactor: MainView commit ece5cd3 Author: David Tonoyan <davidtonoyan10@me.com> Date: Fri Apr 21 13:53:49 2023 +0400 refactor: edits based on comments commit 1cad1c1 Author: David Tonoyan <davidtonoyan10@me.com> Date: Fri Apr 21 02:35:12 2023 +0400 feat: add main view commit 4409330 Author: David Tonoyan <davidtonoyan10@me.com> Date: Fri Apr 21 02:34:51 2023 +0400 feat: add recentFile cell commit a2bb3e4 Author: David Tonoyan <davidtonoyan10@me.com> Date: Fri Apr 21 02:34:40 2023 +0400 feat: add menuItem cell commit 28dd8d7 Author: David Tonoyan <davidtonoyan10@me.com> Date: Fri Apr 21 02:34:11 2023 +0400 feat: add collectionView extension commit 6341e25 Author: David Tonoyan <davidtonoyan10@me.com> Date: Fri Apr 21 02:33:55 2023 +0400 feat: add section manager commit 9c55324 Author: David Tonoyan <davidtonoyan10@me.com> Date: Fri Apr 21 02:33:40 2023 +0400 feat: add localizable string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Очередная попытка слить мою ветку в нужное место)