-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rcpp version of mpoly and mpoly arithmetic #12
base: master
Are you sure you want to change the base?
Conversation
This may be unnecessary as it's done in +.mpoly
This file contains the cpp function reducePoly which handles the bulk of the mpoly function in R, speeding it up quite a bit.
This makes tests pass for mpoly, as it makes all.equal not compare lists, but use the equality of polynomials
Any idea why |
Haven't really done the benchmark or profiling, but when I look at it, it seems that the problem may be that the original R version would just do Those are just my thoughts, as the only difference I can see between the implementations is the lack of Do you have any concrete benchmarks or profiling results for this? Perhaps sticking with the R version of The multiplication |
This fixes the terrible performance of raising polynomials to a power.
That really turned out to be the issue, I added poly reducing now in every loop iteration and it works fast now. |
No description provided.